Differential D24377

Show the correct delete icons in/out of the trash
ClosedPublic
Actions

Authored by ndavis on Oct 3 2019, 6:17 AM.

Details

Reviewers
mlaurent
ngraham
Group Reviewers
VDG
KDE PIM: KMail
Commits
R206:a4d8546a23a0: Show the correct delete icons in/out of the trash
Summary

The edit-delete and edit-delete-shred icons were use in the opposite way they should be. edit-delete-shred is for permanent deletion and when there is a trash, edit-delete is used for moving to the trash.

Test Plan

Old

New

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Oct 3 2019, 6:17 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 3 2019, 6:17 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ndavis requested review of this revision.Oct 3 2019, 6:17 AM
ndavis edited the test plan for this revision. (Show Details)Oct 3 2019, 6:22 AM
ndavis added a reviewer: KDE PIM: KMail.
mlaurent accepted this revision.Oct 3 2019, 6:52 AM
This revision is now accepted and ready to land.Oct 3 2019, 6:52 AM
ngraham accepted this revision.Oct 3 2019, 1:46 PM
Closed by commit R206:a4d8546a23a0: Show the correct delete icons in/out of the trash (authored by ndavis). · Explain WhyOct 3 2019, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/kmmainwidget.cpp (9 lines)

Diff 67271

View Options

src/kmmainwidget.cpp

Loading...