Differential D24317

Delete pointless discardShape method calls
ClosedPublic
Actions

Authored by zzag on Sep 30 2019, 5:14 PM.

Details

Reviewers
None
Group Reviewers
KWin
Commits
R108:a03d70c9a6d7: Delete pointless discardShape method calls
Summary

There's no point for calling discardShape from the destructor of a
Scene::Window subclass because window quads cache will be destroyed
automagically by QScopedPointer.

Diff Detail

Repository
R108 KWin
Branch
dont-call-discard-shape
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 17180
Build 17198: arc lint + arc unit
zzag created this revision.Sep 30 2019, 5:14 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 30 2019, 5:14 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 30 2019, 5:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2019, 8:32 AM
Closed by commit R108:a03d70c9a6d7: Delete pointless discardShape method calls (authored by zzag). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67080

View Options

plugins/scenes/qpainter/scene_qpainter.cpp

Loading...
View Options

plugins/scenes/xrender/scene_xrender.cpp

Loading...