KWin::GLTexture support external textures
ClosedPublic

Authored by davidedmundson on Sep 24 2019, 9:47 PM.

Details

Summary

Currently KWin::GLTexture is a nice wrapper for creating a GL texture
and performing various operations including rendering.

In a pending patch I want to render the FBO from a QQuickScene directly,
where we have an underlying texture already, but it makes sense to
re-use this class for the rendering. A similar need is in haagch's kwin
VR patchset.

This patch adds a constructor to GLTexture that takes an externally
managed texture and provides the relevant useful KWin features.

Test Plan

Used in patch series

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 24 2019, 9:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 24 2019, 9:47 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Sep 24 2019, 9:47 PM
zzag accepted this revision.Sep 25 2019, 9:30 AM
zzag added a subscriber: zzag.
zzag added inline comments.
libkwineffects/kwingltexture.h
63–65

Wrong indentation in the comment and the brief summary has to be on the next line.

This revision is now accepted and ready to land.Sep 25 2019, 9:30 AM
zzag added a comment.Sep 25 2019, 9:34 AM

Also, the subject line needs to be in imperative mood and preferably with libkwineffects scope.

This revision was automatically updated to reflect the committed changes.