Differential D24205

[GTK3] Make selection-mode headerbars closer to Adwaita
ClosedPublic
Actions

Authored by cblack on Sep 24 2019, 8:09 PM.

Details

Reviewers
ngraham
Group Reviewers
Breeze
Commits
R98:1de5b06acc94: [GTK3] Make selection-mode headerbars closer to Adwaita
R98:91f1a35e7b4c: Merge branch 'Plasma/5.17' - Selection-mode fixes
R98:72f5cd46bbff: Update version number for 5.17.80 GIT_SILENT
Summary

Headerbars in selection mode are now colored in a similar manner as in Adwaita.

Test Plan

Before:


After:
Material Dark

Breeze

Adwaita:

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Sep 24 2019, 8:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 24 2019, 8:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sep 24 2019, 8:09 PM
cblack edited the test plan for this revision. (Show Details)Sep 24 2019, 8:10 PM
cblack edited the test plan for this revision. (Show Details)
IlyaBizyaev added a subscriber: IlyaBizyaev.Sep 24 2019, 8:19 PM

Could you show how this change affects the default color scheme?

cblack edited the test plan for this revision. (Show Details)Sep 24 2019, 8:27 PM
ngraham added a subscriber: ngraham.Sep 26 2019, 3:19 PM

Which one of the screenshots depicts how this looks with one of the default color schemes? The one with the purple background or the teal background?

cblack edited the test plan for this revision. (Show Details)Sep 26 2019, 3:24 PM
ngraham accepted this revision.Sep 26 2019, 4:08 PM

5.17 branch please

This revision is now accepted and ready to land.Sep 26 2019, 4:08 PM
Closed by commit R98:1de5b06acc94: [GTK3] Make selection-mode headerbars closer to Adwaita (authored by cblack). · Explain WhySep 26 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/gtk3/widgets/_headerbar.scss (14 lines)

Diff 66903

View Options

src/gtk3/widgets/_headerbar.scss

Loading...