Differential D24189

Mark Toplevel as not ready for painting by default
ClosedPublic
Actions

Authored by zzag on Sep 24 2019, 1:41 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:64feafc10fb5: Mark Toplevel as not ready for painting by default
Summary

Get rid of some duplication as InternalClient, XdgShellClient, Unmanaged,
and Client initialize ready_for_painting to false.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 24 2019, 1:41 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 24 2019, 1:41 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 24 2019, 1:41 PM
zzag edited the summary of this revision. (Show Details)Sep 24 2019, 1:50 PM
davidedmundson added a subscriber: davidedmundson.Sep 24 2019, 1:59 PM

Generally++

Should we set it to true in the Deleted constructor? I imagine it's a special case that no-one queries, but technically it's ready for painting.

zzag added a comment.Sep 24 2019, 2:00 PM
In D24189#536981, @davidedmundson wrote:

Generally++

Should we set it to true in the Deleted constructor? I imagine it's a special case that no-one queries, but technically it's ready for painting.

ready_for_painting gets copied to Deleted

zzag added a comment.Sep 24 2019, 2:03 PM

see Toplevel::copyToDeleted

davidedmundson accepted this revision.Sep 24 2019, 2:04 PM
This revision is now accepted and ready to land.Sep 24 2019, 2:04 PM
Closed by commit R108:64feafc10fb5: Mark Toplevel as not ready for painting by default (authored by zzag). · Explain WhySep 24 2019, 2:05 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 66754