Details
Details
- Reviewers
dvratil - Commits
- R490:a55d6c59e182: More d-pointerization of the public KDAV API
Diff Detail
Diff Detail
- Repository
- R490 KDAV Library
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16881 Build 16899: arc lint + arc unit
Comment Actions
Some small nitpicks, but the code is good to go even without those.
src/common/davcollectionsmultifetchjob.h | ||
---|---|---|
79 ↗ | (On Diff #66608) | I usually mark d-pointers as const to prevent accidental re-assigning other than in constructor. |
src/common/davmanager.cpp | ||
51 ↗ | (On Diff #66608) | I suppose you could just have static DavManager on stack and just return a pointer to it. The static will get initialized on the first call to self() and the initialization is thread-safe. |