Port inbox page model's first test method away from mock
ClosedPublic

Authored by dfaure on Sep 22 2019, 4:30 AM.

Details

Summary

Some notes:

  • Weird to test dnd from the main "shouldList" method rather than

from a dedicated method (but all these pagemodel tests do that...)

  • Weird to be testing dropping to the same destination for both tests

(1 and 2 source items). But that's what the old test was doing.

  • There are other methods to port away from mocks, both here

and in alltaskspagemodeltest which I used as inspiration

Test Plan

Unittest

Diff Detail

Repository
R4 Zanshin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16874
Build 16892: arc lint + arc unit
dfaure requested review of this revision.Sep 22 2019, 4:30 AM
dfaure created this revision.
ervin accepted this revision.Sep 23 2019, 8:27 AM

Note that I agree those "shouldList" tests are too big... I think it ended up that way in part due to the pressure of the setup cost of the mocks. Might be easier to split them in more specific tests later on (I hope so).

This revision is now accepted and ready to land.Sep 23 2019, 8:27 AM
dfaure closed this revision.Sep 23 2019, 2:07 PM