[GTK3] Generate Breeze Light assets
Needs ReviewPublic

Authored by cblack on Sep 20 2019, 10:35 PM.

Details

Reviewers
None
Group Reviewers
Breeze
Summary

Breeze Light assets are now generated to allow bypassing a bug with Chromium where recolorable icons cannot work.

BUG: 412076
FIXED-IN: 5.17

Diff Detail

Repository
R98 Breeze for Gtk
Branch
gen-breeze-light (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16848
Build 16866: arc lint + arc unit
cblack created this revision.Sep 20 2019, 10:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 20 2019, 10:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sep 20 2019, 10:35 PM
cblack edited the summary of this revision. (Show Details)Sep 20 2019, 10:38 PM

Hmm, this doesn't seem to work for me.

Hmm, this doesn't seem to work for me.

Could you elaborate?

Window decoration buttions in Chromium with CSDs and the Breeze Light color scheme don't show any difference with the patch applied and deployed.

Window decoration buttions in Chromium with CSDs and the Breeze Light color scheme don't show any difference with the patch applied and deployed.

This isn't elegant, but it's because of an upstream Chromium bug not allowing recolorable window buttons without issues.
You have to set the GTK theme to the newly generated Breeze Light, not just the color scheme. This is being added to give users a workaround
before upstream bugs get fixed and a version with those bugfixes is released.

(BTW It would be nice if that information were spelled out clearly in the Test Plan section :) )

Oh, gross. Better than nothing I guess, if it's impossible to fix the bug any other way. On the other hand, this feels like it kind of partially defeats the point of making the Breeze GTK theme respect the system's color scheme if we're going to generate multiple versions of it specific to different color schemes. Is there really no other way? Is there an upstream Chromium bug report tracking this on their side?

(BTW It would be nice if that information were spelled out clearly in the Test Plan section :) )

Oh, gross. Better than nothing I guess, if it's impossible to fix the bug any other way. On the other hand, this feels like it kind of partially defeats the point of making the Breeze GTK theme respect the system's color scheme if we're going to generate multiple versions of it specific to different color schemes. Is there really no other way? Is there an upstream Chromium bug report tracking this on their side?

Yeah, there's not really any other way unless you're okay with duplicated, stacked window buttons of different sizes and colors on top of each other. Chromium just doesn't simply separate the CSS nodes necessary to do recolouration without visual glitches. (Mutter when drawing SSDs has the same issue, actually)

I'll file one tonight, since you reminded me that I didn't do that.

Yeah, please do file a bug on Chromium.

I'm hesitant to approve this because once we create a "Breeze Light" GTK theme, will we actually be able to remove it? Also, is the number of people who know that you'll need to use this new GTK theme to solve that specific Chromium bug likely to ever be larger than the set of people who wrote or reviewed this patch? :)