[GTK3] Assorted bugfixes

Authored by cblack on Sep 20 2019, 8:48 PM.


Group Reviewers

This patch includes a series of assorted bugfixes.

  • Menus no longer have a curved highlight unless the new style flag is set
  • Buttons on unfocused windows now show a focus decorator when hovered over
  • Scrollbar states on focus/unfocused windows have been fixed
  • Breeze Light assets are generated to allow users to bypass a bug with Chromium
  • There is now a 5px handle when on a window manager that does not support GTK frame extents
  • Checkboxes in menus/popovers now apply the user's colorscheme properly when hovered

BUG: 412078
BUG: 412080
BUG: 412076
FIXED-IN: 5.17

Test Plan

Menu, before:

Menu, after:

Unfocused button hover before:

Unfocused button hover after:

Scrollbars before:

Scrollbars after:

Handle before (KWin):

Handle after (KWin):

Checkboxes before:

Checkboxes after:

Diff Detail

R98 Breeze for Gtk
bugfixes-09-2019 (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 16846
Build 16864: arc lint + arc unit
cblack created this revision.Sep 20 2019, 8:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 20 2019, 8:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sep 20 2019, 8:48 PM
cblack edited the summary of this revision. (Show Details)Sep 20 2019, 8:49 PM
cblack edited the test plan for this revision. (Show Details)Sep 20 2019, 8:57 PM
ndavis added a subscriber: ndavis.Sep 20 2019, 9:07 PM

Could you separate these into different patches? It's generally not good practice to land a bunch of unrelated changes in one commit.

+1, please split.

cblack abandoned this revision.Sep 20 2019, 10:31 PM