Differential D2410

[wayland] Properly implement minimize of ShellClient
ClosedPublic
Actions

Authored by graesslin on Aug 11 2016, 3:38 PM.

Details

Reviewers
mart
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:8bbd53a77493: [wayland] Properly implement minimize of ShellClient
Summary

We need to call Workspace::clientHidden when minimizing. Otherwise
Workspace doesn't update the active client and the now minimized
window is still active.

BUG: 366634

Test Plan

Test case works now and also tested in nested setup that
active window changes.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 5840.Aug 11 2016, 3:38 PM
graesslin retitled this revision from to [wayland] Properly implement minimize of ShellClient.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptAug 11 2016, 3:38 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 15 2016, 12:53 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 15 2016, 12:53 PM
Closed by commit R108:8bbd53a77493: [wayland] Properly implement minimize of ShellClient (authored by graesslin). · Explain WhyAug 15 2016, 2:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5939

View Options

autotests/integration/shell_client_test.cpp

Loading...
View Options

shell_client.h

Loading...
View Options

shell_client.cpp

Loading...