Differential D24088

Provide progress information during the "merging allocations" phase
ClosedPublic
Actions

Authored by dfaure on Sep 19 2019, 3:49 PM.

Details

Reviewers
mwolff
Commits
R45:33a25cddfc19: Provide progress information during the "merging allocations" phase
Summary

It can take a long time, and I needed the progress information to see
if I had enough RAM to let it finish or if it was never going to work.

Interestingly, this shows that the same loop becomes slower and slower.

Test Plan

heaptrack kmail, read 4-5 emails, quit

Diff Detail

Repository
R45 Heaptrack
Branch
2019_09_progress
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16808
Build 16826: arc lint + arc unit
dfaure requested review of this revision.Sep 19 2019, 3:49 PM
dfaure created this revision.
dfaure updated this revision to Diff 66500.Sep 19 2019, 8:05 PM

Fix division by zero if there are less than 100 allocations

dfaure updated this revision to Diff 66503.Sep 19 2019, 8:30 PM

It's better if I use '%' properly...

mwolff requested changes to this revision.Sep 20 2019, 3:50 AM

one minor nit, otherwise lgtm

src/analyze/gui/parser.cpp
320

std::max<size_t>(1, ...) would be how I write it. please at least std::max

This revision now requires changes to proceed.Sep 20 2019, 3:50 AM
mwolff accepted this revision.Sep 20 2019, 3:50 AM

just pleaes fixup the qMax -> std::max and commit directly

This revision is now accepted and ready to land.Sep 20 2019, 3:50 AM
dfaure closed this revision.Sep 20 2019, 12:05 PM

Revision Contents
Changeset List

PathPackages
Msrc/analyze/gui/parser.cpp (12 lines)

Diff 66503

View Options

src/analyze/gui/parser.cpp

Loading...