Differential D2408

AzimuthalProjection: Avoid duplicated globeHidesPoint calculation in iteration
ClosedPublic
Actions

Authored by kossebau on Aug 11 2016, 2:24 PM.

Details

Reviewers
rahn
Group Reviewers
Marble
Commits
R34:64efed1e3ba2: AzimuthalProjection: Avoid duplicated globeHidesPoint calculation in iteration
Summary

In the first recursive call there is no need to recalculate whether the
currentCoords parameter of AzimuthalProjectionPrivate::findHorizon(...)
is hidden by the globe, because that information is already known on the
previous level.
Splitting the findHorizon() method into a "interface" method and
a "worker" method for the recursion, where the existing information
is passed on, allows to avoid that duplicated calculation.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 5833.Aug 11 2016, 2:24 PM
kossebau retitled this revision from to AzimuthalProjection: Avoid duplicated globeHidesPoint calculation in iteration.
kossebau updated this object.
kossebau added reviewers: Marble, rahn.
rahn accepted this revision.Aug 23 2016, 5:36 PM
rahn edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2016, 5:36 PM
rahn accepted this revision.Aug 23 2016, 5:36 PM
Closed by commit R34:64efed1e3ba2: AzimuthalProjection: Avoid duplicated globeHidesPoint calculation in iteration (authored by kossebau). · Explain WhyAug 23 2016, 5:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6199

View Options

src/lib/marble/projections/AzimuthalProjection.cpp

Loading...
View Options

src/lib/marble/projections/AzimuthalProjection_p.h

Loading...