add tooltips to the intro page
ClosedPublic

Authored by tienisto on Wed, Sep 18, 12:18 PM.

Details

Summary

Add tooltips to the most used settings in the intro page

Test Plan

Move your cursor on one of the most used settings, a tooltip will appear

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tienisto created this revision.Wed, Sep 18, 12:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Sep 18, 12:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tienisto requested review of this revision.Wed, Sep 18, 12:18 PM
tienisto edited the summary of this revision. (Show Details)Wed, Sep 18, 12:20 PM
tienisto added reviewers: ngraham, GB_2.
tienisto updated this revision to Diff 66376.Wed, Sep 18, 12:24 PM

remove unnecessary brackets in onEntered and onExited

In general +1

sidebar/SidebarMode.cpp
581

Is there a strong reason to move these around?

sidebar/ToolTips/tooltipmanager.h
51

Use an Enum here instead of a bool to improve readability. See for example https://codereview.stackexchange.com/questions/11300/boolean-enums-improved-clarity-or-just-overkill

tienisto added inline comments.Wed, Sep 18, 2:14 PM
sidebar/SidebarMode.cpp
581

I want to have all the initializations of tooltip managers in one place. I couldn't add the third manager there because the placeHolderWidget is not initialized yet

tienisto updated this revision to Diff 66387.Wed, Sep 18, 2:49 PM

using enums (ToolTipPosition) instead of booleans

ngraham accepted this revision.Wed, Sep 18, 3:00 PM
This revision is now accepted and ready to land.Wed, Sep 18, 3:00 PM
This revision was automatically updated to reflect the committed changes.