The last fix was not correct as floor is needed. Therefore, this version should serve better.
Details
Details
- Reviewers
ngraham - Group Reviewers
VDG - Commits
- R102:c177c39ef878: Fix the last fix of the max y-range computation
Diff Detail
Diff Detail
- Repository
- R102 KInfoCenter
- Branch
- ymax_again (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16712 Build 16730: arc lint + arc unit
Comment Actions
I still get:
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined
Comment Actions
I have seen this error myself before at another place, which was the scalePoint function if I remember it correctly -- simply where data[index].x is accessed the first time in the code path.
As I haven't touched the data, it can be assumed that's not my fault that those values are undefined for some weird reason.
I will investigate the reason behind this bug later, when I definitely have more time. :)
Comment Actions
This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend.
Regards
Comment Actions
The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ...