Show a new version string description for updates where the old and new versions are identical
ClosedPublic

Authored by ngraham on Sep 16 2019, 7:07 PM.

Details

Summary

This is common for Flatpak runtime updates, where it seems weird to show "3.34 -> 3.34".

With this patch, instead Discover will show "Update to version 3.34", which is more
accurate.

Test Plan

No change for updates where old and new are different or only new version is available

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Sep 16 2019, 7:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 16 2019, 7:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 16 2019, 7:07 PM
apol added a comment.Sep 16 2019, 9:19 PM

Having 3 identical labels with slightly different conditions feels odd, maybe we should just take it into account if when assigning the property?

ngraham updated this revision to Diff 66305.Sep 17 2019, 4:04 PM

Use only a single string

ngraham edited the test plan for this revision. (Show Details)Sep 17 2019, 4:04 PM
ngraham updated this revision to Diff 66306.Sep 17 2019, 4:08 PM

Add a happy little comment

apol accepted this revision.Sep 17 2019, 4:10 PM
This revision is now accepted and ready to land.Sep 17 2019, 4:10 PM
This revision was automatically updated to reflect the committed changes.