Differential D23975

Improve keyboard navigation
ClosedPublic
Actions

Authored by ognarb on Sep 15 2019, 8:03 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Plasma Accessibility
Maniphest Tasks
T7038: System settings: keyboard navigation in the sidebar
Commits
R124:e649d5a706b6: Improve keyboard navigation
Summary

Since the tab view is dead, we should improve the keyboard navigation of the sidebar view.

BUG: 404065
FIXED-IN: 5.17.0

Test Plan

Played a bit with it, it looks like it's working.

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Sep 15 2019, 8:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 15 2019, 8:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Sep 15 2019, 8:03 PM
ngraham added a subscriber: ngraham.Sep 15 2019, 8:28 PM

Definitely better than before!

One use case still doesn't work though: Returning to the first column of the sidebar when you're in the second column and only a single column is visible (i.e. because the window is unmaximized).

ngraham edited the summary of this revision. (Show Details)Sep 15 2019, 8:28 PM
ognarb planned changes to this revision.Sep 15 2019, 8:38 PM
In D23975#532059, @ngraham wrote:

Definitely better than before!

One use case still doesn't work though: Returning to the first column of the sidebar when you're in the second column and only a single column is visible (i.e. because the window is unmaximized).

Good catch, I will try to fix this case too.

ognarb added a comment.Sep 15 2019, 8:52 PM

Looking at the behavior more in details. The 'bug' with a smaller screen should be fixed in kirigami instead. The focus is correct and I can move back the main category and select anoter subcategory. The problem is that Kirigami pageStack should display the page that as focus automaticly.

ognarb requested review of this revision.Sep 15 2019, 8:53 PM
ngraham accepted this revision.Sep 15 2019, 8:56 PM

All right, let's land this then, and fix it in Kirigami. Do you fancy sending a patch for that?

This revision is now accepted and ready to land.Sep 15 2019, 8:56 PM
ognarb added a comment.Sep 15 2019, 8:59 PM

Thanks, I will try to send a kirigami patch, if I don't send anything before the next weekend consider that I forgot ;p

Closed by commit R124:e649d5a706b6: Improve keyboard navigation (authored by ognarb). · Explain WhySep 15 2019, 8:59 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 66158