Differential D2388

[Plasma Calendar Integration] Filter holiday regions case-insensitively
ClosedPublic
Actions

Authored by broulik on Aug 10 2016, 8:15 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R871:7516a8fb9dac: [Plasma Calendar Integration] Filter holiday regions case-insensitively
R120:7516a8fb9dac: [Plasma Calendar Integration] Filter holiday regions case-insensitively
Summary

PlasmaCore.SortFilterModel for some reason doesn't have a case-sensitivity option and filterString always filters case-sensitively whereas filterRegExp explicitly sets it to case-insensitive, so we'll use that for now.

BUG: 365621
FIXED-IN: 5.7.4

Test Plan

Entered "ger", got "Germany", previously I had to enter "Ger"

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5786.Aug 10 2016, 8:15 AM
broulik retitled this revision from to [Plasma Calendar Integration] Filter holiday regions case-insensitively.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 10 2016, 8:15 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 10 2016, 8:15 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 10 2016, 8:15 AM
Closed by commit R120:7516a8fb9dac: [Plasma Calendar Integration] Filter holiday regions case-insensitively (authored by broulik). · Explain WhyAug 10 2016, 10:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5792

View Options

plasmacalendarintegration/HolidaysConfig.qml

Loading...