It doesn't make sense to update window margins in finishInit because no
buffer is attached yet at that moment.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:062303244acc: [wayland] Don't update margins in ShellClient::finishInit
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Yes, but for popups we know the initial size before we have a buffer and window geometry within that is still valid.
Comment Actions
We have to clamp window geometry to bounding rectangle of the surface, including subsurfaces. Initial size in xdg_positioner corresponds to window geometry.
Comment Actions
However we need to react to window geometry changes. I want to address this in 5.18 :-)
Comment Actions
Currently, we call updateWindowMargins() from ShellClient::addDamage() which is not quite accurate.
Comment Actions
However we need to react to window geometry changes. I want to address this in 5.18 :-)
Ack,that's a known TODO.
It's in damage simply because it's analogous to the surface commit.
Initial size in xdg_positioner corresponds to window geometry.
Fair point.