Differential D23719

Don't parse autostart files n-phase times
ClosedPublic
Actions

Authored by apol on Sep 4 2019, 3:35 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:e28eaced917d: Don't parse autostart files n-phase times
Summary

Load only once and share

Test Plan

Restarted. Also made a small test app that I'll submit once this is in as it depends.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16097
Build 16115: arc lint + arc unit
apol created this revision.Sep 4 2019, 3:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 4 2019, 3:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Sep 4 2019, 3:35 PM
davidedmundson accepted this revision.Sep 4 2019, 3:51 PM
davidedmundson added a subscriber: davidedmundson.

Thanks

This revision is now accepted and ready to land.Sep 4 2019, 3:51 PM
davidedmundson added inline comments.Sep 4 2019, 3:53 PM
startkde/plasma-session/autostart.h
34 ↗(On Diff #65371)

Are you sure? We can't memcpy a qstring, it has to update the ref count.

apol marked an inline comment as done.Sep 4 2019, 10:35 PM
apol added inline comments.
startkde/plasma-session/autostart.h
34 ↗(On Diff #65371)

I copied it over, now that you mention it, yes, it doesn't make much sense.

apol updated this revision to Diff 65392.Sep 4 2019, 10:36 PM
apol marked an inline comment as done.

QString isn't movable

Closed by commit R120:e28eaced917d: Don't parse autostart files n-phase times (authored by apol). · Explain WhySep 5 2019, 1:06 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mstartkde/plasma-session/autostart.h (11 lines)

Diff 65392

View Options

startkde/plasma-session/autostart.h

Loading...