| broulik |
| Plasma |
This converts the powerdevil backends into proper plugins that are
loaded at runtime instead of just hardcoding upowerbackend. And are also
seperated from the powerdevil kded. This is first step to have other
modules for example, wayland, hwcomposer etc.
Logic for finding and loading backends is mostly inspired from the
kscreen, currently it just loads upower backend because it is only
module available. This logic can be changed when new backends are
introduced in powedevil.
compiles, builds and installs backend module powerdevilupowerbackend.so
into proper plugin path. Also verified with powerdevil kded that it gets
loaded properly.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Looks good to me.
wayland
Wayland would still use upower but instead of having XRandRBrightness only use sysfs, this needs some more thought on how we could split that in the future, I guess.
| daemon/kdedpowerdevil.cpp | ||
|---|---|---|
| 83 | fileInfos also call reserve() as you later iterate something and add an already known number of items | |
| 84 | const QString &paths | |
| 94 | compare with QLatin1String | |
| 111 | QPluginLoader * | |
| 113–114 | Check for interface being null (cast failed) maybe? | |