Differential D23590

Don't schedule repaint until Compositor is On
ClosedPublic
Actions

Authored by zzag on Aug 30 2019, 10:52 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R108:d690d913fb8e: Don't schedule repaint until Compositor is On
Summary

scheduleRepaint() and addRepaintFull() do nothing when m_state is not State::On.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 30 2019, 10:52 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 30 2019, 10:52 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 30 2019, 10:52 PM
romangg added a subscriber: romangg.Aug 30 2019, 10:57 PM
romangg added inline comments.
composite.cpp
343–344

Is this useless then?

zzag updated this revision to Diff 65022.Aug 30 2019, 11:11 PM

Remove

// This means "start now" - we don't have even a slight idea when the first vsync will occur.
m_timeSinceLastVBlank = fpsInterval - (options->vBlankTime() + 1);
zzag added inline comments.Aug 30 2019, 11:11 PM
composite.cpp
343–344

Yes, looks like it is.

343–344

I still wonder how we manage to render something on the screen because this field is not what it says.

romangg added inline comments.Aug 30 2019, 11:14 PM
composite.cpp
343–344

You mean without the timer? performCompositing call in the end just directly presents without timer.

zzag added inline comments.Aug 30 2019, 11:16 PM
composite.cpp
343–344

No, in general. Hopefully, it'll be over soon. ;-)

romangg accepted this revision.Aug 30 2019, 11:26 PM
This revision is now accepted and ready to land.Aug 30 2019, 11:26 PM
Closed by commit R108:d690d913fb8e: Don't schedule repaint until Compositor is On (authored by zzag). · Explain WhySep 5 2019, 7:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcomposite.cpp (6 lines)

Diff 65403

View Options

composite.cpp

Loading...