Use the new KeySelectionCombo in Identity dialog -> Cryptography
ClosedPublic

Authored by dvratil on Aug 5 2016, 12:22 PM.

Details

Summary

Switch to the new combobox for choosing signing/encryption keys for identity. The combobox only lists keys matched by email of the identity and has a feature to quickly generate a new key pair.

This removes the ability to choose a key with email address different from that of the identity, but I don't think that will affect any users - we can certainly improve on that if there is a negative feedback, but as Andre said, let's design a friendly UI for the 95% of users here rather than having an over-complex UI for 100% users that only 5% understand.

Diff Detail

Repository
R43 KDE PIM
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil updated this revision to Diff 5691.Aug 5 2016, 12:22 PM
dvratil retitled this revision from to Use the new KeySelectionCombo in Identity dialog -> Cryptography.
dvratil updated this object.
dvratil edited the test plan for this revision. (Show Details)
dvratil added reviewers: mlaurent, aheinecke.
dvratil set the repository for this revision to R43 KDE PIM.
dvratil added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim. · View Herald TranscriptAug 5 2016, 12:22 PM
mlaurent requested changes to this revision.Aug 5 2016, 3:17 PM
mlaurent edited edge metadata.

You missed to increase libkleo version in all kdepim + fix tr("...")

kmail/src/identity/identitydialog.cpp
269

tr("...") ?

This revision now requires changes to proceed.Aug 5 2016, 3:17 PM
dvratil updated this revision to Diff 5756.Aug 9 2016, 8:22 AM
dvratil edited edge metadata.
mlaurent accepted this revision.Aug 9 2016, 12:08 PM
mlaurent edited edge metadata.

Seems ok now.

This revision is now accepted and ready to land.Aug 9 2016, 12:08 PM
This revision was automatically updated to reflect the committed changes.