[Colors KCM] Don't explicitly reload KWin's configuration
ClosedPublic

Authored by broulik on Thu, Aug 29, 1:33 PM.

Details

Summary
  • KWin watches decoration palette changes on its own.
  • When Plasma changes its colorscheme it will send new background contrast information to KWin anyway.
  • plasma-integration listens to color scheme changes and updates the QApplication palette,
Test Plan

This code has been in there for over a decade, likely having been neccessary before KDecoration2 was around?

Changed color scheme:

  • No longer have KWin re-initalize its compositor, the overall color scheme change feels a lot less jarring now
  • Decoration color updates immediately
  • Context menu on decoration updates immediately
  • Tabbox stuff updates immediately (plasma theme)
  • The panel flickers funnily during the change but that might have just previously been covered by the fact that KWin drops some frames while reinitializing the compositor?

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Thu, Aug 29, 1:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Aug 29, 1:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Thu, Aug 29, 1:33 PM
broulik edited the summary of this revision. (Show Details)
zzag accepted this revision.Thu, Aug 29, 2:06 PM
This revision is now accepted and ready to land.Thu, Aug 29, 2:06 PM
This revision was automatically updated to reflect the committed changes.