Differential D23539

[autotests] Fix failing autotests
ClosedPublic
Actions

Authored by zzag on Aug 28 2019, 4:08 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R108:7f5f64c0c7bd: [autotests] Fix failing autotests
Summary

After recent output-related changes testIdleInhibition and
testColorCorrectionNightColor started failing with the following output:

❯ dbus-run-session bin/testIdleInhibition
********* Start testing of TestIdleInhibition *********
Config: Using QtTest library 5.13.0, Qt 5.13.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.1.0)
QFATAL : TestIdleInhibition::initTestCase() ASSERT: "mode.size.isValid()" in file /home/vlad/Workspace/KDE/src/frameworks/kwayland/src/server/outputdevice_interface.cpp, line 188
FAIL!  : TestIdleInhibition::initTestCase() Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 0 passed, 1 failed, 0 skipped, 0 blacklisted, 13ms
********* Finished testing of TestIdleInhibition ********

Apparently, they both don't initialize virtual outputs properly.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 28 2019, 4:08 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 28 2019, 4:08 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 28 2019, 4:08 PM
romangg accepted this revision.Aug 28 2019, 4:20 PM
romangg added a subscriber: romangg.

Thank you for the quick fix.

This revision is now accepted and ready to land.Aug 28 2019, 4:20 PM
Closed by commit R108:7f5f64c0c7bd: [autotests] Fix failing autotests (authored by zzag). · Explain WhyAug 28 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64864

View Options

autotests/integration/colorcorrect_nightcolor_test.cpp

Loading...
View Options

autotests/integration/idle_inhibition_test.cpp

Loading...