[GTK3] Recolor CSD titlebuttons according to user's color scheme
ClosedPublic

Authored by cblack on Sun, Aug 25, 6:53 PM.

Details

Summary

Window titlebuttons on CSD windows now respect the user's colorscheme, preventing colorschemes such as Breeze Light, which has black on white instead of white on dark window buttons, from having barely discernable window buttons.

Chrome/ium has been exempted from this due to bugs from the Chromium side of things.

Test Plan



Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Sun, Aug 25, 6:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Aug 25, 6:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sun, Aug 25, 6:53 PM
cblack edited the test plan for this revision. (Show Details)Sun, Aug 25, 6:55 PM
cblack edited the summary of this revision. (Show Details)Mon, Aug 26, 3:02 PM
ngraham accepted this revision.Mon, Aug 26, 3:21 PM
This revision is now accepted and ready to land.Mon, Aug 26, 3:21 PM
ognarb added a subscriber: ognarb.Mon, Aug 26, 4:40 PM

Could it be possible to remove most of the code duplication between _window_decorations.scss and _chromium.scss?

cblack updated this revision to Diff 64698.Mon, Aug 26, 8:24 PM

DRY that code

ognarb accepted this revision.Mon, Aug 26, 8:30 PM

Much better now thanks :)

This revision was automatically updated to reflect the committed changes.