Simplify ctors with default member initializer
AbandonedPublic

Authored by dhaumann on Thu, Aug 22, 3:38 PM.

Details

Summary

Moves values into header, making it's easier to read variable's
default state. Also compiler checks types more carefully.

Test Plan

If it compiles, then it should be ok.
Code doesn't change behavior.

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15474
Build 15492: arc lint + arc unit
gawin created this revision.Thu, Aug 22, 3:38 PM
Restricted Application added a project: Kate. · View Herald TranscriptThu, Aug 22, 3:38 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gawin requested review of this revision.Thu, Aug 22, 3:38 PM
gawin added a subscriber: Kate.Thu, Aug 22, 3:40 PM
gawin added a reviewer: Kate.Thu, Aug 22, 3:42 PM
dhaumann accepted this revision.Thu, Aug 22, 5:02 PM
dhaumann added a subscriber: dhaumann.

Looks good to me!

This revision is now accepted and ready to land.Thu, Aug 22, 5:02 PM
dhaumann commandeered this revision.Thu, Aug 22, 5:20 PM
dhaumann edited reviewers, added: gawin; removed: dhaumann.

Since Kate is now developed on gitlab, I committed this manually now and will close this
Commit: https://invent.kde.org/kde/kate/commit/748f181a37f03a369df5867f36ec0ea86c454fe1

This revision now requires review to proceed.Thu, Aug 22, 5:20 PM
dhaumann abandoned this revision.Thu, Aug 22, 5:21 PM

Sorry for "abandoning", I should not have commandeered this revision, instead I should have simply closed it.
In any case, this patch is committed, see: https://invent.kde.org/kde/kate/commit/748f181a37f03a369df5867f36ec0ea86c454fe1