gawin (Filip Gawin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 15 2017, 10:46 PM (103 w, 6 d)
Availability
Available

Recent Activity

Sun, Nov 10

gawin committed R40:94f5aaf81148: Remove redundant and c style casts (authored by gawin).
Remove redundant and c style casts
Sun, Nov 10, 7:08 PM

Sat, Oct 19

gawin committed R40:0636221dc0ab: Bump required version of qt to 5.10 (authored by gawin).
Bump required version of qt to 5.10
Sat, Oct 19, 7:42 PM

Sep 6 2019

gawin committed R40:969d52c16b78: Avoid using `size` for checking emptiness (authored by gawin).
Avoid using `size` for checking emptiness
Sep 6 2019, 9:27 PM
gawin committed R40:8f1d312ff0b5: Cleanup inheritance specifiers (authored by gawin).
Cleanup inheritance specifiers
Sep 6 2019, 2:27 PM

Aug 23 2019

gawin committed R40:850793397b92: Avoid copying if it's possible (authored by gawin).
Avoid copying if it's possible
Aug 23 2019, 7:12 PM

Aug 22 2019

gawin added a reviewer for D23351: Simplify ctors with default member initializer: Kate.
Aug 22 2019, 3:42 PM · Kate
gawin added a comment to D23035: Simplify ctors with default member initializer.

I've tried to use arc for this. It created new PR. https://phabricator.kde.org/D23351

Aug 22 2019, 3:41 PM · Kate
gawin updated subscribers of D23351: Simplify ctors with default member initializer.
Aug 22 2019, 3:40 PM · Kate
gawin requested review of D23351: Simplify ctors with default member initializer.
Aug 22 2019, 3:38 PM · Kate

Aug 9 2019

gawin added a comment to D23035: Simplify ctors with default member initializer.

@cullmann: Filip Gawin, filip.gawin@zoho.com

Aug 9 2019, 9:35 AM · Kate
gawin requested review of D23035: Simplify ctors with default member initializer.
Aug 9 2019, 12:33 AM · Kate

Aug 8 2019

gawin added a comment to D23010: Use range loop if possible.

It's ok, unless you don't "stand behind" this code. ;)

Aug 8 2019, 12:11 PM · Kate
gawin updated the diff for D23010: Use range loop if possible.

Fixes to avoid detach (if possible).

Aug 8 2019, 11:28 AM · Kate

Aug 7 2019

gawin added a comment to D23010: Use range loop if possible.

qAsConst has problems if we want to take addr to object:

for (auto& pluginInfo : qAsConst(m_pluginList)) {
    m_name2Plugin[pluginInfo.saveName()] = &pluginInfo;
}

&pluginInfo will be const ptr.

Aug 7 2019, 9:11 PM · Kate
gawin added inline comments to D23010: Use range loop if possible.
Aug 7 2019, 7:51 PM · Kate
gawin requested review of D23010: Use range loop if possible.
Aug 7 2019, 7:46 PM · Kate

May 5 2019

gawin added a comment to D20737: Convert c arrays to std::array.

I'm not sure what has happened - I attached patch with 2 commits, but only one is visible.

May 5 2019, 9:00 PM · Dolphin
gawin updated the diff for D20737: Convert c arrays to std::array.

Dived code

May 5 2019, 8:59 PM · Dolphin

Apr 26 2019

gawin added a comment to D20737: Convert c arrays to std::array.

C++ 17 (only :( ) allows to change:

struct someClass{...};
Apr 26 2019, 4:01 PM · Dolphin

Apr 22 2019

gawin requested review of D20737: Convert c arrays to std::array.
Apr 22 2019, 1:55 PM · Dolphin