Differential D2334

Respect the bottomPadding for the bottom of the drawer
ClosedPublic
Actions

Authored by apol on Aug 2 2016, 11:54 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:7f92f7f9a314: Respect the bottomPadding for the bottom of the drawer
Summary

Use Layout attached property margins rather than trying to compute sizes

Diff Detail

Repository
R169 Kirigami
Branch
margins
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 5630.Aug 2 2016, 11:54 AM
apol retitled this revision from to Respect the bottomPadding for the bottom of the drawer.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 2 2016, 11:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added inline comments.Aug 2 2016, 11:58 AM
src/controls/GlobalDrawer.qml
269–273

leftovers from old patch

310

this line is what the patch should be

apol updated this revision to Diff 5633.Aug 2 2016, 12:14 PM

Update patch

mart added inline comments.Aug 2 2016, 12:17 PM
src/controls/GlobalDrawer.qml
269–273

leftPadding

270

rightPadding

apol updated this revision to Diff 5635.Aug 2 2016, 12:17 PM

Use padding to place the top element as well

apol updated this revision to Diff 5636.Aug 2 2016, 12:20 PM

Use padding when necessary

mart accepted this revision.Aug 2 2016, 12:20 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2016, 12:20 PM
Closed by commit R169:7f92f7f9a314: Respect the bottomPadding for the bottom of the drawer (authored by apol). · Explain WhyAug 2 2016, 12:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/GlobalDrawer.qml (15 lines)

Diff 5636

View Options

src/controls/GlobalDrawer.qml

Loading...