Differential D2328

Speed up loading KCM with FileDialog lazy loading
ClosedPublic
Actions

Authored by davidedmundson on Aug 1 2016, 10:05 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R119:60e970472a5e: Speed up loading KCM with FileDialog lazy loading
Summary

FileDialog is very slow to load. Despite us using the platform theme is
will also load the /entire/ fallback dialog in QML on startup; with
tableviews and all, even though it obviously will never be shown.

(See cbd0666 in QQC. It's apparently deliberate...though don't ask me to
explain it.)

As a bonus win, it works round a bug in TableView:
https://bugreports.qt.io/browse/QTBUG-54752 which can crash.

Test Plan

"time kcmshell5 desktoptheme" a few times shows 0.9 seconds of CPU time
Clicking the install button still works.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 5614.Aug 1 2016, 10:05 PM
davidedmundson retitled this revision from to Speed up loading KCM with FileDialog lazy loading.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 1 2016, 10:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Aug 2 2016, 5:50 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Aug 2 2016, 5:50 AM
Closed by commit R119:60e970472a5e: Speed up loading KCM with FileDialog lazy loading (authored by davidedmundson). · Explain WhyAug 2 2016, 10:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5629

View Options

kcms/desktoptheme/package/contents/ui/main.qml

Loading...