Differential D2327

Let the drawer contents take the full width
ClosedPublic
Actions

Authored by apol on Aug 1 2016, 4:05 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:cf7ea0a6adda: Let the drawer contents take the full width
Summary

I'm not sure why it was done like that, but otherwise we're forced into
some margins which look weird, especially when having ListItems at the
bottom, because they don't look like the ones on top

For reference:
Before: http://i.imgur.com/nAdxT8F.png
After: http://i.imgur.com/0oksXoo.png

Test Plan

Works on kirigamigallery, works on Discover

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 5609.Aug 1 2016, 4:05 PM
apol retitled this revision from to Let the drawer contents take the full width.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 1 2016, 4:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart edited edge metadata.Aug 1 2016, 4:59 PM

i'm concerned existing applicatons will look broken as they risk the drawer to not have margins and is very probablt text will arrive to the very end of the drawer edge.
all the components are designed for the developernot to have set margins by hand (because assumes, from past experience that the developer just won't do that)

apol updated this object.Aug 1 2016, 9:47 PM
apol edited edge metadata.
Closed by commit R169:cf7ea0a6adda: Let the drawer contents take the full width (authored by apol). · Explain WhyAug 1 2016, 10:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/GlobalDrawer.qml (4 lines)

Diff 5615

View Options

src/controls/GlobalDrawer.qml

Loading...