[platforms/x11/standalone] Fix stored refresh rate
ClosedPublic

Authored by romangg on Mon, Aug 19, 2:31 PM.

Details

Summary

With 1a11abc821f4 X11 standalone plugin uses the AbstractOutput interface for
managing its outputs. In there the refresh rate is stored in 1/μs.

Test Plan

currentRefreshRate() provides correct rate.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mon, Aug 19, 2:31 PM
Restricted Application added a project: KWin. · View Herald TranscriptMon, Aug 19, 2:31 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Mon, Aug 19, 2:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Aug 20, 12:03 PM
This revision was automatically updated to reflect the committed changes.
zzag added a subscriber: zzag.Tue, Aug 20, 1:24 PM

In there the refresh rate is stored in 1/μs.

That's actually incorrect. The resulting frequency will be in MHz, not in mHz!

Let's expand 1/μs = 1000/ms a bit further just to be sure

1/μs = 1 000/ms = 1 000 000/s = 1 000 000 (1/s) = 1 000 000 Hz = 1 MHz
zzag added a comment.Tue, Aug 20, 1:27 PM

refreshRate, geometry, and gammaRampSize are documented in AbstractOutput. I suggest removing all redundant doxygen documentation in X11Output.