Fix crash on "Close Current Tab" handling
ClosedPublic

Authored by AndreyYashkin on Sun, Aug 18, 7:56 PM.

Details

Summary

_pluggedController disconnection happens when session is closed
by closeInNormalWay or closeInForceWay and calling
disconnectController leads to Konsole crash. Also a case when
closeInNormalWay is false was not considered.

BUG: 410607
FIXED-IN: 19.08.1

Test Plan
  1. Open Konsole
  2. Open one more tab
  3. Try to close Konsole
  4. Pick option "Close Current Tab" (assuming you have not check 'Do not ask again')

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
AndreyYashkin created this revision.Sun, Aug 18, 7:56 PM
Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptSun, Aug 18, 7:56 PM
AndreyYashkin requested review of this revision.Sun, Aug 18, 7:56 PM
hindenburg accepted this revision.Sun, Aug 18, 8:47 PM
hindenburg retitled this revision from Improve "Close Current Tab" handling to Fix crash on "Close Current Tab" handling.
hindenburg edited the summary of this revision. (Show Details)
hindenburg edited the test plan for this revision. (Show Details)
hindenburg added a subscriber: hindenburg.

Thanks a lot for fixing this - please don't add // italic/bold to commit messages as it messes up what shows up in the logs

This revision is now accepted and ready to land.Sun, Aug 18, 8:49 PM
This revision was automatically updated to reflect the committed changes.

if possible, use https://invent.kde.org/kde/konsole/merge_requests instead of phrabicator. I don't mind using phrabicator while it is still up abut I often forget to amend the author.