D22040 broke the build of Spectacle with KConfig <= 5.56.0, because older KConfig needs Q_FOREACH. 5.53.0 is still the target KF5 version for Spectacle 19.08.
Details
Details
- Reviewers
davidre ngraham - Group Reviewers
Spectacle - Commits
- R166:b3337d18458e: Allow Spectacle to build with KConfig <= 5.56.0
Tested on KConfig 5.54.0 (the last version that works with Qt 5.9 LTS). Builds and runs correctly.
Diff Detail
Diff Detail
- Repository
- R166 Spectacle
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Or we could just bump the frameworks dep version to 5.56. It's 5 months old, and by the time Spectacle 19.12 is released, it'll be 9 months old. I think that's sane enough to do.
Comment Actions
If you really want to do that on the 19.12 branch, feel free.
But I think it is a little unfair to require that bump on an already released branch (19.08).