Differential D23072

refactor: Minimize use of geom in Toplevel subclasses
ClosedPublic
Actions

Authored by zzag on Aug 10 2019, 2:45 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R108:744e2be3f626: refactor: Minimize use of geom in Toplevel subclasses
Summary

This change makes easier to refactor geometry handling in the future.
The main motivation for avoiding using geom directly is to make code
more readable and ensure that the geometry is updated only through
designated methods, e.g. setGeometry, plainResize, etc.

Diff Detail

Repository
R108 KWin
Branch
dont-use-geom
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14951
Build 14969: arc lint + arc unit
zzag created this revision.Aug 10 2019, 2:45 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 10 2019, 2:45 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 10 2019, 2:45 PM
zzag updated this revision to Diff 63487.Aug 10 2019, 2:48 PM

Capture only clientGeometry.

romangg accepted this revision.Aug 10 2019, 3:28 PM
romangg added a subscriber: romangg.

That's good. I hate this geom member variable without m_.

This revision is now accepted and ready to land.Aug 10 2019, 3:28 PM
Closed by commit R108:744e2be3f626: refactor: Minimize use of geom in Toplevel subclasses (authored by zzag). · Explain WhyAug 10 2019, 5:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mabstract_client.cpp (6 lines)
Mshell_client.cpp (19 lines)

Diff 63487

View Options

abstract_client.cpp

Loading...
View Options

shell_client.cpp

Loading...