refactor: Minimize use of geom in Toplevel subclasses
ClosedPublic

Authored by zzag on Sat, Aug 10, 2:45 PM.

Details

Summary

This change makes easier to refactor geometry handling in the future.
The main motivation for avoiding using geom directly is to make code
more readable and ensure that the geometry is updated only through
designated methods, e.g. setGeometry, plainResize, etc.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sat, Aug 10, 2:45 PM
Restricted Application added a project: KWin. · View Herald TranscriptSat, Aug 10, 2:45 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sat, Aug 10, 2:45 PM
zzag updated this revision to Diff 63487.Sat, Aug 10, 2:48 PM

Capture only clientGeometry.

romangg accepted this revision.Sat, Aug 10, 3:28 PM
romangg added a subscriber: romangg.

That's good. I hate this geom member variable without m_.

This revision is now accepted and ready to land.Sat, Aug 10, 3:28 PM
This revision was automatically updated to reflect the committed changes.