Add a basic threshold filter
ClosedPublic
Actions

Authored by rempt on Jul 28 2016, 12:21 PM.

Details

Reviewers

dkazakov

Group Reviewers

Krita

Summary

This is a very basic threshold filter based on the intensity8 method of KoColorSpace.

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

rempt retitled this revision from to Add a basic threshold filter.

rempt updated this object.

rempt edited the test plan for this revision. (Show Details)

rempt added a reviewer: Krita.

rempt set the repository for this revision to R37 Krita.

rempt added a subscriber: Krita.

The patch works fine. There are two small issues, that can be fixed right before the commit.

plugins/filters/threshold/threshold.cpp
95	It is much faster to cache the pixelSize value in a 'const int' variable that is defined outside the loop. The main purpose of KisSequentialIterator is to avoid virtual calls that make iteration up to 2-5 times faster and here we have at least two virtual calls :)
plugins/filters/threshold/threshold.h
53	As far as I can tell, this value is used in the GUI menu, so it should actually be "Threshold...", because it creates a new dialog

This revision is now accepted and ready to land.Aug 1 2016, 9:41 AM

		Path
M		libs/ui/widgets/kis_gradient_slider.h (5 lines)
M		libs/ui/widgets/kis_gradient_slider.cpp (20 lines)
M		plugins/filters/CMakeLists.txt (1 line)
A	M	plugins/filters/threshold/CMakeLists.txt (9 lines)
A	M	plugins/filters/threshold/kritathreshold.json (9 lines)
A	M	plugins/filters/threshold/threshold.h (91 lines)
A	M	plugins/filters/threshold/threshold.cpp (219 lines)
A	M	plugins/filters/threshold/wdg_threshold.ui (186 lines)