Fix detection of broken 7z multivolumes archives
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 27 2016, 4:10 PM.

Details

Reviewers

Commits

R36:d570b04dff14: Fix detection of 7z multivolumes archives with missing volumes

Summary

The crash we were facing can be fixed by refactoring handleLine(). The function
now just returns a boolean and the task of calling killProcess() is moved to the
caller (readStdout()).

Test Plan

Doesn't crash anymore when opening a broken multipart 7z.
Let's make sure this doesn't break anything else...

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 5528.Jul 27 2016, 4:10 PM

elvisangelaccio retitled this revision from to Fix detection of broken 7z multivolumes archives.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptJul 27 2016, 4:10 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Nick work! :)

This revision is now accepted and ready to land.Jul 27 2016, 7:01 PM

Btw: We can remove Qt::DirectConnection now, since m_process and CliInterface are in the same thread so direct connection is the default.

Closed by commit R36:d570b04dff14: Fix detection of 7z multivolumes archives with missing volumes (authored by elvisangelaccio). · Explain WhyJul 28 2016, 9:51 AM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:d570b04dff14: Fix detection of 7z multivolumes archives with missing volumes.

Revision Contents
Changeset List

			Path	Packages
M			kerfuffle/cliinterface.h (8 lines)
M			kerfuffle/cliinterface.cpp (50 lines)
M			plugins/cli7zplugin/cliplugin.cpp (2 lines)
M			plugins/cliunarchiverplugin/cliplugin.h (2 lines)
M			plugins/cliunarchiverplugin/cliplugin.cpp (16 lines)