Differential D2287

cliunarchiver: fix opening header-encrypted archives
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 25 2016, 5:56 PM.

Details

Reviewers
rthomsen
Commits
R36:3b8f60b61968: cliunarchiver: fix opening header-encrypted archives
Summary

cliunarchiver plugin was never ported to the new "non-blocking" way.
This patch implements that and fixes header-encrypted archives.

Test Plan

Disable clirar from arkrc. Open an header-encrypted archive and make sure Ark doesn't
crash.

Note that there is a crash if the password is wrong, but this looks like
another issue that should be fixed separately.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 5497.Jul 25 2016, 5:56 PM
elvisangelaccio retitled this revision from to cliunarchiver: fix opening header-encrypted archives.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptJul 25 2016, 5:56 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Jul 25 2016, 6:18 PM
rthomsen edited edge metadata.

Looks good!

This revision is now accepted and ready to land.Jul 25 2016, 6:18 PM

Revision Contents
Changeset List

Diff 5517

View Options

kerfuffle/cliinterface.h

Loading...
View Options

kerfuffle/cliinterface.cpp

Loading...
View Options

plugins/cliunarchiverplugin/cliplugin.h

Loading...
View Options

plugins/cliunarchiverplugin/cliplugin.cpp

Loading...