kdesvn: cleanup/c++11'ify
ClosedPublic
Actions

Authored by chehrlic on Jul 31 2019, 10:00 AM.

Details

Reviewers

Summary

These were 11 separate patches in git but arc merged them into one. For review this should be fine, will commit the patches separately later on.

Diff Detail

Repository

R220 Subversion Client (KDE SVN)

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14599
Build 14617: arc lint + arc unit

chehrlic requested review of this revision.Jul 31 2019, 10:00 AM

chehrlic created this revision.

Harbormaster completed remote builds in B14598: Diff 62833.Jul 31 2019, 10:00 AM

svnqt/cache: use range-based for loops
svnfrontend: use range-based for loops
svnfrontend/models: use range-based for loops
svnfrontend: use range-based for loops, use member-initialization instead custom ctors, use auto instead foo<bar>::iterator
svnfrontend/svnactions: use range-based for loops

Harbormaster completed remote builds in B14599: Diff 62835.Jul 31 2019, 10:00 AM

I tried hard to find a problem, but I couldn't. Good job :-)

This revision is now accepted and ready to land.Aug 1 2019, 7:52 AM

uploaded without arcanist to have 11 separate commits

Revision Contents
Changeset List

			Path	Packages
M			src/kiosvn/kiosvn.cpp (36 lines)
M			src/ksvnwidgets/commitmsg_impl.cpp (8 lines)
M			src/ksvnwidgets/models/commitmodel.cpp (9 lines)
M			src/ksvnwidgets/ssltrustprompt.cpp (4 lines)
M			src/svnfrontend/background/getinfothread.cpp (5 lines)
M			src/svnfrontend/blamedisplay.h (2 lines)
M			src/svnfrontend/blamedisplay.cpp (59 lines)
M			src/svnfrontend/cacheentry.h (71 lines)
M			src/svnfrontend/fronthelpers/propertylist.cpp (3 lines)
M			src/svnfrontend/fronthelpers/watchedprocess.cpp (17 lines)
M			src/svnfrontend/graphtree/revisiontree.cpp (5 lines)
M			src/svnfrontend/maintreewidget.cpp (29 lines)
M			src/svnfrontend/models/logitemmodel.h (10 lines)
M			src/svnfrontend/models/logitemmodel.cpp (26 lines)
M			src/svnfrontend/models/logmodelhelper.cpp (3 lines)
M			src/svnfrontend/models/svnitemmodel.cpp (48 lines)
M			src/svnfrontend/svnactions.cpp (148 lines)
M			src/svnfrontend/svntreeview.h (5 lines)
M			src/svnfrontend/svntreeview.cpp (10 lines)
M			src/svnqt/cache/LogCache.cpp (21 lines)
M			src/svnqt/cache/ReposLog.cpp (30 lines)
M			src/svnqt/client_status.cpp (6 lines)
M			src/svnqt/dirent.cpp (47 lines)
M			src/svnqt/entry.cpp (8 lines)
M			src/svnqt/helper.h (21 lines)
M			src/svnqt/log_entry.h (4 lines)
M			src/svnqt/log_entry.cpp (4 lines)
M			src/svnqt/path.h (5 lines)
M			src/svnqt/path.cpp (10 lines)
M			src/svnqt/status.cpp (38 lines)
M			src/svnqt/stringarray.h (2 lines)
M			src/svnqt/stringarray.cpp (19 lines)
M			src/svnqt/targets.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62833	40c0143		Jul 31 2019, 9:52 AM	★	★
Diff 2	62835	40c0143	- svnqt/cache: use range-based for loops	Jul 31 2019, 10:00 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
fad99d443f01	ba6e1dd7f28e	38f8df1baad1	Christian Ehrlicher	svnfrontend/svnactions: use range-based for loops	Jul 31 2019, 9:13 AM
38f8df1baad1	cf110acbf2a3	593ea7c5fbc0	Christian Ehrlicher	svnfrontend: use range-based for loops, use member-initialization instead… (Show More…)	Jul 31 2019, 9:12 AM
593ea7c5fbc0	9d7a0fbe31e7	3730eee96ce5	Christian Ehrlicher	svnfrontend/models: use range-based for loops	Jul 31 2019, 9:09 AM
3730eee96ce5	b60e09e24a54	d5f465263d0b	Christian Ehrlicher	svnfrontend: use range-based for loops	Jul 31 2019, 9:08 AM
d5f465263d0b	12cee1970681	3700ed6df1f8	Christian Ehrlicher	svnqt/cache: use range-based for loops	Jul 31 2019, 9:03 AM
3700ed6df1f8	62095b2cd3f8	c3eb2c6759b4	Christian Ehrlicher	svnqt: use range-based for loops	Jul 31 2019, 9:01 AM
c3eb2c6759b4	be0e0cbe8656	a3b5c8cdeba6	Christian Ehrlicher	kiosvn/ksvnwidgets: use range-based for loops, dont' emit dataChanged() twice… (Show More…)	Jul 31 2019, 9:00 AM
a3b5c8cdeba6	334540e86b13	c49dec75b4ab	Christian Ehrlicher	StringArray: remove unused functions StringArray::operator[], use range-based… (Show More…)	Jul 31 2019, 9:03 AM
c49dec75b4ab	245ccd9fee84	d0bfbbb72760	Christian Ehrlicher	SvnTreeView: remove useless ctor, SvnLogModel: add override	Jul 15 2019, 12:03 PM
d0bfbbb72760	888ae0b493bc	bb3aabe1ed46	Christian Ehrlicher	Rearrage members for some classes to adjust paddings	Jul 15 2019, 11:58 AM
bb3aabe1ed46	df7dc98b0a80	40c0143de01a	Christian Ehrlicher	Remove useless svn::Path copy operator - the compiler can create a valid one by… (Show More…)	Jul 15 2019, 11:48 AM