Fix failures in autotest templateparserjobtest
ClosedPublic

Authored by gjditchfield on Jul 30 2019, 1:54 PM.

Details

Summary

templateparserjobtest suffers 3 failures in test_replyHtml() at lines

QVERIFY(parser->d->mOtp->htmlContent().isEmpty());
QVERIFY(!parser->d->mOtp->plainTextContent().isEmpty());

I think these lines were added accidentally.

  • If I understand the git history, they were added in revision a13359849ef0, "Merge branch 'Applications/19.04'", but they don't exist on the 19.04 branch or the previous master revision.
  • The first line verifies that htmlContent is empty, but later the test checks for expected HTML content.
  • test_replyHtml() has similar structure to test_replyPlain(), test_forwardplain(), and test_forwardHtml(), which do not have similar tests.

This patch deletes the lines.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gjditchfield created this revision.Jul 30 2019, 1:54 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 30 2019, 1:54 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
gjditchfield requested review of this revision.Jul 30 2019, 1:54 PM
dvratil accepted this revision.Aug 5 2019, 11:52 AM
dvratil added a subscriber: dvratil.

I think your analysis is correct, the merge commit indeed looks suspicious and misplaced in this test. Well spotted!

This revision is now accepted and ready to land.Aug 5 2019, 11:52 AM
This revision was automatically updated to reflect the committed changes.