Improved OSD behavior
ClosedPublic

Authored by broulik on Jul 29 2019, 11:07 AM.

Details

Summary

Don't ask the user for a screen configuration on login, instead, apply a sane default.
When connecting a new screen, apply a default configuration so the user gets immediate feedback "something's happening" and then prompt for a configuration via the OSD in case the chosen default doesn't fit.

BUG: 398816

Test Plan

The login case is especially annoying as it would usually choose a sane default and then the user would choose Cancel which won't save a config and then kscreen asks again next time until the user choses anyhting but Cancel.

Nuked my kscreen config, restarted kded, two screens attached, had kscreen apply a default config for my two screens without asking.
Nuked my kscreen config, unplugged one monitor, restarted kded, plugged in second screen, KScreen applied a sane default (though it cannot know that the screens are swapped), and showed the OSD which I then used to swap the monitors "extend left" to how they should be

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 29 2019, 11:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 29 2019, 11:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 29 2019, 11:07 AM
ngraham edited the summary of this revision. (Show Details)Aug 1 2019, 10:27 PM
ngraham accepted this revision.Aug 2 2019, 3:24 PM
ngraham added a subscriber: ngraham.

Works great for me.

This revision is now accepted and ready to land.Aug 2 2019, 3:24 PM
This revision was automatically updated to reflect the committed changes.