Differential D22773

Further clean up addons CMake scripts.
ClosedPublic
Actions

Authored by daandemeyer on Jul 27 2019, 10:47 AM.

Details

Reviewers

cullmann

Group Reviewers

Kate

Commits

R40:c4cfdf3b1b6e: Further clean up addons CMake scripts.

Summary

Reduce addon dependencies to the bare minimum required.
Move source files out of sessionapplet/engine directory for consistency with the other addons.
Ensure each addon is built only if all of its dependencies are found.
Remove .kateconfig file in close-expect-like addon directory.
Remove comments with no added value.

Test Plan

Make sure builds as before with the same (or an extended) set of addons.

Diff Detail

Repository

R40 Kate

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

daandemeyer created this revision.Jul 27 2019, 10:47 AM

Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptJul 27 2019, 10:47 AM

daandemeyer requested review of this revision.Jul 27 2019, 10:47 AM

Ok with this.

This revision is now accepted and ready to land.Jul 27 2019, 5:00 PM

Closed by commit R40:c4cfdf3b1b6e: Further clean up addons CMake scripts. (authored by cullmann). · Explain WhyJul 27 2019, 5:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		addons/CMakeLists.txt (83 lines)
M		addons/backtracebrowser/CMakeLists.txt (8 lines)
M		addons/backtracebrowser/autotests/CMakeLists.txt (1 line)
D	M	addons/close-except-like/.kateconfig (1 line)
M		addons/close-except-like/CMakeLists.txt (9 lines)
M		addons/filebrowser/CMakeLists.txt (12 lines)
M		addons/filetree/CMakeLists.txt (11 lines)
M		addons/filetree/autotests/CMakeLists.txt (1 line)
M		addons/gdbplugin/CMakeLists.txt (14 lines)
M		addons/kate-ctags/CMakeLists.txt (9 lines)
M		addons/katebuild-plugin/CMakeLists.txt (9 lines)
M		addons/katesql/CMakeLists.txt (60 lines)
M		addons/konsole/CMakeLists.txt (15 lines)
M		addons/lspclient/CMakeLists.txt (14 lines)
M		addons/lspclient/tests/CMakeLists.txt (8 lines)
M		addons/lumen/CMakeLists.txt (6 lines)
M		addons/openheader/CMakeLists.txt (9 lines)
M		addons/preview/CMakeLists.txt (8 lines)
M		addons/project/CMakeLists.txt (28 lines)
M		addons/project/autotests/CMakeLists.txt (1 line)
M		addons/replicode/CMakeLists.txt (8 lines)
M		addons/rustcompletion/CMakeLists.txt (8 lines)
M		addons/search/CMakeLists.txt (10 lines)
M		addons/sessionapplet/CMakeLists.txt (36 lines)
D	M	addons/sessionapplet/engine/CMakeLists.txt (27 lines)
V		addons/sessionapplet/{engine → }/katesessionsengine.h
V		addons/sessionapplet/{engine → }/katesessionsengine.cpp
V		addons/sessionapplet/{engine → }/katesessionsjob.h
V		addons/sessionapplet/{engine → }/katesessionsjob.cpp
V		addons/sessionapplet/{engine → }/katesessionsmodel.h
V		addons/sessionapplet/{engine → }/katesessionsmodel.cpp
V		addons/sessionapplet/{engine → }/katesessionsservice.h
V		addons/sessionapplet/{engine → }/katesessionsservice.cpp
V		addons/sessionapplet/{engine → }/org.kde.plasma.katesessions.operations
V		addons/sessionapplet/{engine → }/plasma-dataengine-katesessions.desktop
V		addons/sessionapplet/{ ← engine}/katesessionsengine.h
V		addons/sessionapplet/{ ← engine}/katesessionsengine.cpp
V		addons/sessionapplet/{ ← engine}/katesessionsjob.h
V		addons/sessionapplet/{ ← engine}/katesessionsjob.cpp
V		addons/sessionapplet/{ ← engine}/katesessionsmodel.h
V		addons/sessionapplet/{ ← engine}/katesessionsmodel.cpp
V		addons/sessionapplet/{ ← engine}/katesessionsservice.h
V		addons/sessionapplet/{ ← engine}/katesessionsservice.cpp
V		addons/sessionapplet/{ ← engine}/org.kde.plasma.katesessions.operations
V		addons/sessionapplet/{ ← engine}/plasma-dataengine-katesessions.desktop
M		addons/snippets/CMakeLists.txt (13 lines)
M		addons/symbolviewer/CMakeLists.txt (10 lines)
M		addons/tabswitcher/CMakeLists.txt (10 lines)
M		addons/tabswitcher/autotests/CMakeLists.txt (1 line)
M		addons/textfilter/CMakeLists.txt (10 lines)
M		addons/xmlcheck/CMakeLists.txt (11 lines)
M		addons/xmltools/CMakeLists.txt (11 lines)