Fix handling of drag'n'drop adding files to archives
ClosedPublic
Actions

Authored by rthomsen on Jul 23 2016, 4:07 PM.

Details

Reviewers

elvisangelaccio

Commits

Summary

This diff does two things:

Set multi-volume archives to read-only (only when non-empty).
Show a KMessageWidget when user drags files to a read-only archive or encrypted archive when password is unknown.

We cant set encrypted archives with unknown password to read-only, because we still want to support deleting files from them.

Test Plan

Open existing multi-volume archive and check that it's readonly.
Open existing multi-volume archive (or other read-only archive type) and try d'n'd adding files.
Open existing non-he pwd-protected archive and try d'n'd adding files.

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rthomsen retitled this revision from to Fix handling of drag'n'drop adding files to archives.

rthomsen updated this object.

rthomsen edited the test plan for this revision. (Show Details)

rthomsen set the repository for this revision to R36 Ark.

rthomsen added a project: Ark.

Looks good and it works. Pleask ask for string approval as discussed :)

This revision is now accepted and ready to land.Jul 23 2016, 4:25 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kerfuffle/archive_kerfuffle.cpp (3 lines)
M			part/archivemodel.h (2 lines)
M			part/archivemodel.cpp (7 lines)
M			part/part.h (2 lines)
M			part/part.cpp (5 lines)