Fix preview of nested archives
ClosedPublic

Authored by elvisangelaccio on Jul 22 2016, 2:10 PM.

Details

Summary

My assumption that a PreviewJob can remove its temp dir when it's done was
wrong, at least with nested archives. If we remove the extracted file too
soon, there is no way to preview a nested archive or, worse, a "double-nested"
archive.

This patch just delays the cleanup to the Part destructor (= when we are
closing the app).

Test Plan

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Fix preview of nested archives.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptJul 22 2016, 2:10 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Jul 22 2016, 7:12 PM
rthomsen edited edge metadata.

Works for me!

This revision is now accepted and ready to land.Jul 22 2016, 7:12 PM
This revision was automatically updated to reflect the committed changes.