Differential D22579

Load QtQuickSettings from ksplashqml
ClosedPublic
Actions

Authored by davidedmundson on Jul 20 2019, 11:29 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:c7c5f9a1a7e9: Load QtQuickSettings from ksplashqml
Test Plan

Code is copy/paste

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 20 2019, 11:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jul 20 2019, 11:29 AM
apol added a subscriber: apol.Jul 20 2019, 12:39 PM

What does this fix?

davidedmundson added a comment.Jul 20 2019, 1:23 PM

What does this fix?

Fabian's laptop :D

It means the ksplash will apply software rendering/which render loop/GL profile as determined by your settings in "kcmshell5 qtquicksettings".
plasma-workspace, systemsettings etc apply it, I missed ksplash.

apol accepted this revision.Jul 20 2019, 2:13 PM

Then please improve a better commit message (and possibly close using BUG?).

This revision is now accepted and ready to land.Jul 20 2019, 2:13 PM
Closed by commit R120:c7c5f9a1a7e9: Load QtQuickSettings from ksplashqml (authored by davidedmundson). · Explain WhyJul 26 2019, 9:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62591

View Options

ksplash/ksplashqml/CMakeLists.txt

Loading...
View Options

ksplash/ksplashqml/main.cpp

Loading...