[ComboBox] Set close policy to close on click outside instead of only outside parent
ClosedPublic

Authored by broulik on Jul 17 2019, 1:15 PM.

Details

Summary

Ensures clicking the ComboBox itself closes the popup as it does with widget QComboBox.
While Qt documentation for Popup says that is the default, QQuickComboBox explicitly overwrites it to be CloseOnPressOutsideParent instead for whatever reason.
For our usecase the CloseOnPressOutside behavior makes more sense.

BUG: 408950

Test Plan
  • Opened QQC2 combobox, clicked on it again, it closed :) Tested in both plasma config dialog (wallpaper config) and a QML KCM (colors)

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 17 2019, 1:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 17 2019, 1:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 17 2019, 1:15 PM
broulik edited the test plan for this revision. (Show Details)

I'm not seeing any change from this patch in the wallpaper chooser page for example. Clicking on the combobox while the popup is open still doesn't close it.

ngraham accepted this revision.Jul 18 2019, 3:16 PM

Yeah ok, this works in my VM, so there must be something weird about how it's getting installed into ~/kde/usr for my built-from-source stuff. Shipit!

This revision is now accepted and ready to land.Jul 18 2019, 3:16 PM
This revision was automatically updated to reflect the committed changes.