Differential D22497

Remove as deprecated marked classes and functions
ClosedPublic
Actions

Authored by hriesenbeck on Jul 16 2019, 7:16 PM.

Details

Reviewers

apol

Group Reviewers

KDE Edu

Commits

R340:e3d6d4fe5ade: Remove as deprecated marked classes and functions

Summary

The in Qt 5.13 as deprecated respectively obsolete marked classes,
methods and functions were substituted by its, in the compiler
message or documentation suggested, alternatives.

Test Plan

Compiler runs without warnings

Diff Detail

Repository

R340 Parley

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hriesenbeck created this revision.Jul 16 2019, 7:16 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 16 2019, 7:16 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

hriesenbeck requested review of this revision.Jul 16 2019, 7:16 PM

Harbormaster completed remote builds in B14017: Diff 61871.Jul 16 2019, 7:16 PM

Overall, looks good to me. :)

src/dashboard/dashboard.cpp
228–231	add this as a 3rd argument.
src/editor/editor.cpp
144–145	Add this as third argument: `connect(languageSpellCheck, &QAction::triggered, this, [=] {m_vocabularyView->checkSpelling(i);});`
src/editor/summarywordwidget.cpp
61–62	You can use QOverload::of(), it reads easier.
src/settings/languagepropertiespage.cpp
43–44	QOverload
src/statistics/statisticsmainwindow.cpp
133–148	This, to all.

Implement changes based on review comments

Harbormaster completed remote builds in B14050: Diff 61922.Jul 17 2019, 3:59 PM

Thanks!
Can you land patches?

This revision is now accepted and ready to land.Jul 18 2019, 12:34 PM

Closed by commit R340:e3d6d4fe5ade: Remove as deprecated marked classes and functions (authored by hriesenbeck). · Explain WhyJul 18 2019, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

			Path	Packages
M			src/dashboard/dashboard.cpp (18 lines)
M			src/editor/editor.cpp (7 lines)
M			src/editor/summarywordwidget.cpp (3 lines)
M			src/settings/languagepropertiespage.cpp (3 lines)
M			src/statistics/statisticsmainwindow.cpp (35 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61871	8bbf3f8		Jul 16 2019, 7:16 PM	★	★
Diff 2	61922	8bbf3f8	- Implement changes based on review comments	Jul 17 2019, 3:59 PM	★	★
Diff 3	61985	8bbf3f8	R340:e3d6d4fe5ade170021c421dc80bba908b050f138	Jul 18 2019, 3:32 PM	★	★

Diff 61985

View Options

src/dashboard/dashboard.cpp

View Options

src/editor/editor.cpp

View Options

src/editor/summarywordwidget.cpp

View Options

src/settings/languagepropertiespage.cpp

View Options

src/statistics/statisticsmainwindow.cpp

Remove as deprecated marked classes and functionsClosedPublicActions

Details

Diff Detail

Showing Only Differences

Revision ContentsChangeset List

Diff 61985

src/dashboard/dashboard.cpp

src/editor/editor.cpp

src/editor/summarywordwidget.cpp

src/settings/languagepropertiespage.cpp

src/statistics/statisticsmainwindow.cpp

Remove as deprecated marked classes and functions
ClosedPublic
Actions

Revision Contents
Changeset List