Scaling y/x with respect to x/y_min, x/y_max
ClosedPublic

Authored by Murmele on Jul 16 2019, 7:05 PM.

Diff Detail

Repository
R262 LabPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Murmele created this revision.Jul 16 2019, 7:05 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 16 2019, 7:05 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Murmele requested review of this revision.Jul 16 2019, 7:05 PM
Murmele updated this revision to Diff 62692.Jul 28 2019, 7:31 PM
Murmele updated this revision to Diff 62694.Jul 28 2019, 8:00 PM
Murmele updated this revision to Diff 62928.Aug 1 2019, 6:54 PM

rebased

Murmele updated this revision to Diff 62934.Aug 1 2019, 8:23 PM
Murmele updated this revision to Diff 63031.Aug 3 2019, 7:52 PM
Murmele updated this revision to Diff 63094.Aug 5 2019, 7:11 AM
yurchor added a subscriber: yurchor.Aug 5 2019, 7:16 AM

Thanks in advance for fixing these minor issues.

src/backend/core/column/Column.cpp
1247

Should be "\p startIndex and \p endIndex" to not break Doxygen syntax.

1251

This line should be removed.

1345

Should be "\p startIndex and \p endIndex" to not break Doxygen syntax.

1349

This line should be removed.

src/backend/worksheet/plots/cartesian/XYCurve.cpp
2490

This line should be removed.

Murmele marked 5 inline comments as done.Aug 7 2019, 7:05 PM
Murmele updated this revision to Diff 63310.Aug 7 2019, 7:24 PM
  • Fix comments
  • set autoscale when zomming in
Murmele updated this revision to Diff 63457.Aug 10 2019, 8:01 AM
Murmele updated this revision to Diff 63459.Aug 10 2019, 8:10 AM
Murmele updated this revision to Diff 63477.Aug 10 2019, 1:04 PM
asemke accepted this revision.Aug 10 2019, 1:20 PM

Works fine now. I'll replace param by p as requested by @yurchor and push this commit for you. Thanks.

This revision is now accepted and ready to land.Aug 10 2019, 1:20 PM
Closed by commit R262:96ecba5a1ae1: [worksheet] when doing auto-scaling in the plot, respect the current data… (authored by Martin Mamsoler <martin.marmsoler@gmail.com>, committed by asemke). · Explain WhyAug 10 2019, 1:22 PM
This revision was automatically updated to reflect the committed changes.