Differential D22485

wrap the details example label+spacer in a container widget
ClosedPublic
Actions

Authored by sitter on Jul 16 2019, 11:08 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R871:5a59721d7efe: wrap the details example label+spacer in a container widget
Summary

this way we can control both their visibility in a single call. with the
previous code we'd only set the label as hidden and leave a dangling
spacer to mess with the layout.

BUG: 409807

Test Plan
  • segv dolphin -> report -> layout shows example
  • segv systemsettings5 -> report -> layout shows no example but is correctly spaced

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jul 16 2019, 11:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 16 2019, 11:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jul 16 2019, 11:08 AM
sitter edited the test plan for this revision. (Show Details)Jul 16 2019, 11:09 AM
sitter added a reviewer: Plasma.
sitter updated this revision to Diff 62037.Jul 19 2019, 9:16 AM

reduce noise I think

sitter updated this revision to Diff 62038.Jul 19 2019, 9:17 AM

reduce noise no2

apol accepted this revision.Jul 20 2019, 9:05 AM
This revision is now accepted and ready to land.Jul 20 2019, 9:05 AM
apol added a comment.Jul 20 2019, 9:05 AM

When doing this kind of changes it would be useful to have a screenshot by it.

sitter added a comment.Jul 20 2019, 10:31 PM

bug had one. but true enough

FTR:

without this diff

with this diff

Closed by commit R871:5a59721d7efe: wrap the details example label+spacer in a container widget (authored by sitter). · Explain WhyJul 20 2019, 10:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62158

View Options

src/bugzillaintegration/reportassistantpages_base.cpp

Loading...
View Options

src/bugzillaintegration/ui/assistantpage_bugawareness.ui

Loading...