[kcm] Show output name in output preview
ClosedPublic

Authored by sebas on Jul 21 2016, 2:47 PM.

Details

Summary

When identical displays are connected, the identify overlay would display
the output name, while the preview in the kcm displays the display vendor
and model. There's no way to tell which display is which.

This patch adds a row in the output preview, it moves the vendor up,displays and displays the output name underneath (if not duplicated).

BUG:362570

Before:

After:

Test Plan

started kcm with multiple displays connected, I can now distinguish them
based on the name of the connector

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sebas updated this revision to Diff 5390.Jul 21 2016, 2:47 PM
sebas retitled this revision from to [kcm] Show output name in output preview.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 21 2016, 2:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

generally looks ok to me.

kcm/qml/Output.qml
254

this one looks confusing to my: why is the vendor compared to output.name? Just from reading it, one doesn't assume that root.output.name is also the vendor.

sebas updated this object.Jul 21 2016, 2:50 PM
sebas removed a subscriber: graesslin.
sebas added inline comments.
kcm/qml/Output.qml
254

This label may show the output name, if it does, don't show it again.

graesslin accepted this revision.Jul 22 2016, 8:12 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jul 22 2016, 8:12 AM
This revision was automatically updated to reflect the committed changes.